Messages in this thread | | | Subject | Re: assert/crash in __rmqueue() when enabling CONFIG_NUMA | From | Dave Hansen <> | Date | Fri, 05 May 2006 07:33:10 -0700 |
| |
On Fri, 2006-05-05 at 09:55 -0400, Bob Picco wrote: > - if (!page_is_buddy(buddy, order)) > + if (page_in_zone_hole(buddy)) > + break; > + else if (page_zonenum(buddy) != page_zonenum(page)) > + break; > + else if (!page_is_buddy(buddy, order)) > break; /* Move the buddy up one level. */
The page_zonenum() checks look good, but I'm not sure I understand the page_in_zone_hole() part. If a page is in a hole in a zone, it will still have a valid mem_map entry, right? It should also never have been put into the allocator, so it also won't ever be coalesced.
I'm a bit confused. :(
BTW, I like the idea of just aligning HIGHMEM's start because it has no runtime cost. Buuuuut, it is still just a shift and compare of the two page->flags, which should already be (or will soon anyway be) in the cache.
-- Dave
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |