lkml.org 
[lkml]   [2006]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: assert/crash in __rmqueue() when enabling CONFIG_NUMA
    From
    Date
    On Fri, 2006-05-05 at 09:55 -0400, Bob Picco wrote:
    > - if (!page_is_buddy(buddy, order))
    > + if (page_in_zone_hole(buddy))
    > + break;
    > + else if (page_zonenum(buddy) != page_zonenum(page))
    > + break;
    > + else if (!page_is_buddy(buddy, order))
    > break; /* Move the buddy up one level. */

    The page_zonenum() checks look good, but I'm not sure I understand the
    page_in_zone_hole() part. If a page is in a hole in a zone, it will
    still have a valid mem_map entry, right? It should also never have been
    put into the allocator, so it also won't ever be coalesced.

    I'm a bit confused. :(

    BTW, I like the idea of just aligning HIGHMEM's start because it has no
    runtime cost. Buuuuut, it is still just a shift and compare of the two
    page->flags, which should already be (or will soon anyway be) in the
    cache.

    -- Dave

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-05 16:36    [W:4.416 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site