Messages in this thread | | | Date | Fri, 5 May 2006 16:03:14 +1000 | From | Paul Mackerras <> | Subject | Re: [PATCH 04/13] cell: remove broken __setup_cpu_be function |
| |
Arnd Bergmann writes:
> From: Geoff Levand <geoffrey.levand@am.sony.com> > > This patch removes the incorrect Cell processor setup routine > __setup_cpu_be. This routine improperly accesses the hypervisor > page size configuration at SPR HID6. The correct behavior is for > firmware, or if needed, platform setup code, to set the correct > page size.
> - .cpu_setup = __setup_cpu_be, > + .cpu_setup = __setup_cpu_power4,
That looks a bit dodgy. Either just remove the contents of __setup_cpu_be (leaving only the blr), or define a __setup_cpu_null that does nothing, or make the identify_cpu not call the cpu setup function if the pointer is NULL.
Paul. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |