lkml.org 
[lkml]   [2006]   [May]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix x86 microcode driver handling of multiple matching revisions
>> +		for_each_online_cpu(cpu_num) {
>> + if (ucode_cpu_info[cpu_num].mc == uci->mc) {
>> + uci->mc = NULL;
>> + break;
>> + }
>
>Isn't there a memory leak here? Shouldn't this be
> for_each_online_cpu(cpu) {
> if (cpu == cpu_num)
> continue;
> if (ucode_cpu_info[cpu].mc == uci->mc) {
> uci->mc = NULL;
> break;
> }
> }

Indeed, I'll send an updated patch later.

Jan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-05 08:52    [W:0.097 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site