Messages in this thread | | | Date | Thu, 4 May 2006 07:42:59 -0700 | From | Greg KH <> | Subject | Re: [PATCH] s390: Hypervisor File System |
| |
On Thu, May 04, 2006 at 12:22:42PM +0200, Michael Holzheu wrote: > Greg KH <greg@kroah.com> wrote on 05/04/2006 12:10:37 AM: > > > > Fine with me! Then I will create /sys/hypervisor/s390. Should I > > > create /sys/hypervisor in the hpyfs code or should it be > > > created somewhere else? > > > > Somewhere else is probably best. > > > > drivers/base/hypervisor.c ? > > > > We could do that, but then we have to create two new files > hypervisor.c and hypervisor.h just for one new mountpoint > in sysfs. > > I would suggest do do it like /sys/kernel and put the code > into kernel/ksysfs.c and include/linux/kobject.h
No, if you do that then every kernel gets that mount point, when almost no one really wants it :)
If you leave it as a separate file, then the build system can just include the file as needed.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |