Messages in this thread | | | From | Kumar Gala <> | Subject | Re: Please pull from 'for_paulus' branch of powerpc | Date | Thu, 4 May 2006 17:10:56 -0500 |
| |
On May 4, 2006, at 5:09 PM, Segher Boessenkool wrote:
> Hi Kumar, > >> +static int ppc_panic_event(struct notifier_block *this, >> + unsigned long event, void *ptr) >> +{ >> + ppc_md.panic((char *)ptr); /* May not return */ >> + return NOTIFY_DONE; >> +} > > Lose the redundant pointer cast while you're there please? > >> void __init setup_arch(char **cmdline_p) >> { >> extern void do_init_bootmem(void); >> + extern void setup_panic(void); > > Can those two go into a header file please?
any suggestions on which header? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |