lkml.org 
[lkml]   [2006]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: assert/crash in __rmqueue() when enabling CONFIG_NUMA
Bob Picco wrote:
> Ingo Molnar wrote: [Thu May 04 2006, 03:25:28PM EDT]
>
>>* Bob Picco <bob.picco@hp.com> wrote:
>>
>>
>>>Dave Hansen wrote: [Thu May 04 2006, 11:21:06AM EDT]
>>>
>>>>I haven't thought through it completely, but these two lines worry me:
>>>>
>>>>
>>>>>+ start = pgdat->node_start_pfn & ~((1 << (MAX_ORDER - 1)) - 1);
>>>>>+ end = start + pgdat->node_spanned_pages;
>>>>
>>>>Should the "end" be based off of the original "start", or the aligned
>>>>"start"?
>>>
>>>Yes. I failed to quilt refresh before sending. You mean end should be
>>>end = pgdat->node_start_pfn + pgdat->node_spanned_pages before
>>>rounding up.
>>
>>do you have an updated patch i should try?
>>
>> Ingo
>
> You can try this but don't believe it will change your outcome. I've
> booted this on ia64 with slight modification to eliminate
> VIRTUAL_MEM_MAP and have only DISCONTIGMEM. Your case is failing at the
> front edge of of the zone and not the ending edge which had a flaw in my
> first post of the patch. I would have expected the first patch to handle
> the front edge correctly.
>
> I don't remember seeing your .config in the thread (or blind and unable
> to see it). Would you please send it my way.
>
> I'm also hoping Andy has time to look into this.
>
> bob

Yeah will have a look tommorrow my time. Could you drop me the .config
too. There is definatly some unstated requirements on alignment, which
I was testing today. I presume its one of those thats being violated.

-apw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-04 23:53    [W:0.076 / U:1.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site