lkml.org 
[lkml]   [2006]   [May]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 6/13: eCryptfs] Superblock operations
    Date
    Pekka Enberg <penberg@cs.helsinki.fi> wrote:

    > > + ecryptfs_printk(KERN_DEBUG, "Enter; inode = [%p]\n", inode);
    > > + crypt_stat = &(ECRYPTFS_INODE_TO_PRIVATE(inode))->crypt_stat;
    > > + ecryptfs_destruct_crypt_stat(crypt_stat);
    > > + kmem_cache_free(ecryptfs_inode_info_cache,
    > > + ECRYPTFS_INODE_TO_PRIVATE(inode));
    >
    > Better to introduce a local variable for CRYPTFS_INODE_TO_PRIVATE.
    > More readable and smaller kernel text that way.

    But it may use more stack, which is a much more limited resource, so what you
    suggest is not necessarily the best thing to do.

    David
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-04 23:44    [W:5.936 / U:0.036 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site