Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH 6/13: eCryptfs] Superblock operations | Date | Thu, 04 May 2006 22:40:49 +0100 |
| |
Pekka Enberg <penberg@cs.helsinki.fi> wrote:
> > + ecryptfs_printk(KERN_DEBUG, "Enter; inode = [%p]\n", inode); > > + crypt_stat = &(ECRYPTFS_INODE_TO_PRIVATE(inode))->crypt_stat; > > + ecryptfs_destruct_crypt_stat(crypt_stat); > > + kmem_cache_free(ecryptfs_inode_info_cache, > > + ECRYPTFS_INODE_TO_PRIVATE(inode)); > > Better to introduce a local variable for CRYPTFS_INODE_TO_PRIVATE. > More readable and smaller kernel text that way.
But it may use more stack, which is a much more limited resource, so what you suggest is not necessarily the best thing to do.
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |