Messages in this thread | | | Date | Thu, 4 May 2006 11:44:46 -0500 (CDT) | From | Brent Casavant <> | Subject | Re: [PATCH] SGI IOC4: Detect IO card variant |
| |
On Wed, 3 May 2006, Andrew Morton wrote:
> On Wed, 3 May 2006 17:21:23 -0500 (CDT) > Brent Casavant <bcasavan@sgi.com> wrote: > > > +#ifndef PCI_DEVICE_ID_QLOGIC_ISP12160 > > +#define PCI_DEVICE_ID_QLOGIC_ISP12160 0x1216 > > +#endif > > +#ifndef PCI_VENDOR_ID_VITESSE > > +#define PCI_VENDOR_ID_VITESSE 0x1725 > > +#endif > > +#ifndef PCI_DEVICE_ID_VITESSE_7174 > > +#define PCI_DEVICE_ID_VITESSE_7174 0x7174 > > +#endif > > We shouldn't need the ifdefs here. Let's just get the right defines in the > right place and use them.
I'll submit a patch for this today.
> I'm unable to work out whether this problem which this patch fixes warrants > a 2.6.17 merge.
Not really, as the new IO9-RT card which what the patch is primarily for isn't shipping yet. If it's in -mm, then I think SGI will be able to get our distribution partner to pick it up, which is honestly 90% of my concern at this point.
Brent
-- Brent Casavant All music is folk music. I ain't bcasavan@sgi.com never heard a horse sing a song. Silicon Graphics, Inc. -- Louis Armstrong - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |