lkml.org 
[lkml]   [2006]   [May]   [4]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
/
DateThu, 04 May 2006 07:52:22 +0100
FromDavid Vrabel <>
SubjectRe: [PATCH 2/2] ipg: redundancy with mii.h
Francois Romieu wrote:
> 
>     ipg: remove forward declarations
> 
>     It makes no sense in a new driver.
> 
>     Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Ack.

>     ipg: replace #define with enum
> 
>     Added some underscores to improve readability.
> 
>     Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>

Nack.  Register names in code should match those used in the 
documentation (even if they are a bit unreadable).  Though I will 
conceed that the available datasheet doesn't actually describe the 
majority of the registers.

>     ipg: removal of useless #defines
> 
>     IPG_TX_NOTBUSY apart (one occurence in ipg.c), the #defines appear
>     nowhere in the sources.

Ack.

>     ipg: redundancy with mii.h - take II
> 
>     Replace a bunch of #define with their counterpart from mii.h
> 
>     It is applied to the usual MII registers this time.

Ack.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-04 06:54    [from the cache]
©2003-2008