lkml.org 
[lkml]   [2006]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] iWARP Connection Manager.
On Wed, May 31, 2006 at 12:24:42PM -0700, Roland Dreier wrote:
> > > + cm_id_priv = kzalloc(sizeof *cm_id_priv, GFP_KERNEL);
>
> > Please put paren's after sizeof, it is not required by C but it
> > is easier to read.
>
> I disagree -- I hate seeing sizeof look like a function call.

CodingStyle isn't explicit on this issue, but it does use parens in an
example demonstrating how to pass the size of a struct to kmalloc.

(grepping and comparing numbers for both usages in the code left as an
exercise to the bored).

Cheers,
Muli
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-31 23:09    [W:2.074 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site