lkml.org 
[lkml]   [2006]   [May]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] iWARP Connection Manager.
From
Date
On Wed, 2006-05-31 at 12:24 -0700, Roland Dreier wrote:
> > > + cm_id_priv = kzalloc(sizeof *cm_id_priv, GFP_KERNEL);
>
> > Please put paren's after sizeof, it is not required by C but it
> > is easier to read.
>
> I disagree -- I hate seeing sizeof look like a function call.
>

For the most part, drivers/infiniband/core uses sizeof without
parentheses. So I think the correct answer here is to keep the iwcm.c
file in line with the rest of the core.


Steve.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-31 23:00    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site