Messages in this thread | | | Date | Wed, 31 May 2006 22:35:53 +0200 | From | Arjan van de Ven <> | Subject | Re: 2.6.17-rc5-mm1 - output of lock validator |
| |
Andrew Morton wrote: > On Wed, 31 May 2006 16:28:59 +0200 > Arjan van de Ven <arjan@linux.intel.com> wrote: > >> --- linux-2.6.17-rc5-mm1.5.orig/drivers/net/8390.c >> +++ linux-2.6.17-rc5-mm1.5/drivers/net/8390.c >> @@ -299,7 +299,7 @@ static int ei_start_xmit(struct sk_buff >> >> disable_irq_nosync(dev->irq); >> >> - spin_lock(&ei_local->page_lock); >> + spin_lock_irqsave(&ei_local->page_lock, flags); > > Again, notabug - we did disable_irq().
but does disable_irq() work in the light of that irqpoll stuff?
maybe the idiom is no longer really valid... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |