lkml.org 
[lkml]   [2006]   [May]   [30]   [last100]   RSS Feed
Views: [more markup]  [less markup]  [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    DateTue, 30 May 2006 15:03:14 +0400
    FromAlexey Dobriyan <>
    SubjectRe: [patch 03/61] lock validator: sound/oss/emu10k1/midi.c cleanup
    On Tue, May 30, 2006 at 12:51:53PM +0200, Takashi Iwai wrote:
    > At Mon, 29 May 2006 18:33:17 -0700,
    > Andrew Morton wrote:
    > > 
    > > On Mon, 29 May 2006 23:23:19 +0200
    > > Ingo Molnar <mingo@elte.hu> wrote:
    > > 
    > > > move the __attribute outside of the DEFINE_SPINLOCK() section.
    > > > 
    > > > Signed-off-by: Ingo Molnar <mingo@elte.hu>
    > > > Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
    > > > ---
    > > >  sound/oss/emu10k1/midi.c |    2 +-
    > > >  1 file changed, 1 insertion(+), 1 deletion(-)
    > > > 
    > > > Index: linux/sound/oss/emu10k1/midi.c
    > > > ===================================================================
    > > > --- linux.orig/sound/oss/emu10k1/midi.c
    > > > +++ linux/sound/oss/emu10k1/midi.c
    > > > @@ -45,7 +45,7 @@
    > > >  #include "../sound_config.h"
    > > >  #endif
    > > > 
    > > > -static DEFINE_SPINLOCK(midi_spinlock __attribute((unused)));
    > > > +static __attribute((unused)) DEFINE_SPINLOCK(midi_spinlock);
    > > > 
    > > >  static void init_midi_hdr(struct midi_hdr *midihdr)
    > > >  {
    > > 
    > > I'll tag this as for-mainline-via-alsa.
    > 
    > Acked-by: Takashi Iwai <tiwai@suse.de>
    > 
    > 
    > It's OSS stuff, so feel free to push it from your side ;)
    
    Why it is marked unused when in fact it's used?
    
    [PATCH] Mark midi_spinlock as used
    
    Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
    ---
    --- a/sound/oss/emu10k1/midi.c
    +++ b/sound/oss/emu10k1/midi.c
    @@ -45,7 +45,7 @@
     #include "../sound_config.h"
     #endif
     
    -static DEFINE_SPINLOCK(midi_spinlock __attribute((unused)));
    +static DEFINE_SPINLOCK(midi_spinlock);
     
     static void init_midi_hdr(struct midi_hdr *midihdr)
     {
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at  http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at  http://www.tux.org/lkml/
    
    
    \
     
     \ /
      Last update: 2006-05-30 13:07    [from the cache]
    ©2003-2008