lkml.org 
[lkml]   [2006]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/9] [I/OAT] Driver for the Intel(R) I/OAT DMA engine
On Tue, May 23, 2006 at 05:20:13PM -0700, Chris Leech wrote:
> Adds a new ioatdma driver
>
> Signed-off-by: Chris Leech <christopher.leech@intel.com>
> ---
>
> drivers/dma/Kconfig | 9
> drivers/dma/Makefile | 1
> drivers/dma/ioatdma.c | 839 +++++++++++++++++++++++++++++++++++++++
> drivers/dma/ioatdma.h | 126 ++++++
> drivers/dma/ioatdma_hw.h | 52 ++
> drivers/dma/ioatdma_io.h | 118 +++++
> drivers/dma/ioatdma_registers.h | 126 ++++++
> 7 files changed, 1271 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/dma/Kconfig b/drivers/dma/Kconfig
> index f9ac4bc..0f15e76 100644
> --- a/drivers/dma/Kconfig
> +++ b/drivers/dma/Kconfig
> @@ -10,4 +10,13 @@ config DMA_ENGINE
> DMA engines offload copy operations from the CPU to dedicated
> hardware, allowing the copies to happen asynchronously.
>
> +comment "DMA Devices"
> +
> +config INTEL_IOATDMA
> + tristate "Intel I/OAT DMA support"
> + depends on DMA_ENGINE && PCI
> + default m
> + ---help---
> + Enable support for the Intel(R) I/OAT DMA engine.
> +
> endmenu
>...

- please don't use "default m"
- can you enhance the help text?
e.g. you could list which hardware contains this DMA engine

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-31 01:30    [W:0.244 / U:1.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site