Messages in this thread | | | Date | Tue, 30 May 2006 16:19:17 -0700 | From | Chris Wright <> | Subject | Re: [stable] [PATCH 2.6.16.18 0/4] sbp2: workaround for buggy iPods |
| |
* Stefan Richter (stefanr@s5r6.in-berlin.de) wrote: > There is a firmware bug in several Apple iPods which prevents access to > these iPods under certain conditions. The disk size reported by the iPod > is one sector too big. Once access to the end of the disk is attempted, > the iPod becomes inaccessible. This problem has been known for USB iPods > for some time and has recently been discovered to exist with > FireWire/USB combo iPods too. > > The following patchset is the fix as it exists in Linux 2.6.17-rc. Alas > it is rather large, therefore it may be unfit for -stable as it is. If > there are objections, I would appreciate suggestions how to better adapt > this fix for -stable.
Just to be clear, we're talking about this fix:
+ if (scsi_id->workarounds & SBP2_WORKAROUND_FIX_CAPACITY) + sdev->fix_capacity = 1;
with patches 1 and 2 consolidating workaround logic, and 4 adding the command line override.
I'd feel better to let this bit diverge in -stable to have the two-line patch rather than all 4 patches. Could you do detection sbp2_probe(), set a flag in scsi_id_instance_data, and use that in slave_configure?
thanks, -chris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |