lkml.org 
[lkml]   [2006]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [patch 06/61] lock validator: add __module_address() method
From
Date
On Mon, 2006-05-29 at 18:33 -0700, Andrew Morton wrote:

>
> I'd suggest that __module_address() should do the same thing, from an API neatness
> POV. Although perhaps that's mot very useful if we didn't take a ref on the returned
> object (but module_text_address() doesn't either).
>
> Also, the name's a bit misleading - it sounds like it returns the address
> of a module or something. __module_any_address() would be better, perhaps?

How about __valid_module_address() so that it describes exactly what it
is doing. Or __module_address_valid().

-- Steve

>
> Also, how come this doesn't need modlist_lock()?


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-30 19:47    [W:0.233 / U:0.424 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site