lkml.org 
[lkml]   [2006]   [May]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRE: [PATCH 1/1] scsi : megaraid_{mm,mbox}: a fix on 64-bit DMAcapability check
Date
From
Hi,

> Well, this really isn't quite right. There are 32 bit platforms which
> will refuse a 64 bit DMA mask on principle. You need to
> retry with a 32
> bit mask before erroring out, exactly like you've done in
> megaraid_sas.c
>
> Also, it's a bit strange having a 32 bit mask set initially
> in probe_one
> and then being reset in init_mbox. Why not just consolidate
> all the PCI
> register testing and mask setting in probe_one?
Thank you for the points!
A patch containing these changes will followed, soon.

Seokmann
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-30 15:01    [W:0.158 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site