![]() | |||||||||||
Messages in this thread |
On Mon, 2006-05-29 at 08:41, Zhang, Yanmin wrote: > On Fri, 2006-05-26 at 21:50, Greg KH wrote: > > On Fri, May 26, 2006 at 02:35:16PM +0800, Zhang, Yanmin wrote: > > > pci_walk_bus has a race with pci_destroy_dev. In the while loop, > > > when the callback function is called, dev pointed by next might be > > > freed and erased. So later on access to dev might cause kernel panic. > > > > Have you seen this happen? The only user of this function is the PPC64 > > EEH handler, which last time I checked, didn't run on Intel based > > processors :) > I am enabling PCI-Express AER in kernel and want to use it. After > double-checking, I found the lock is not good. How about changing pci_bus_lock to a sema? I think it's the thorough approach. As the write lock is used only when initializing and uninitializing, the performance won't be hurted severely. Thanks, Yanmin - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2006-05-29 10:12 [from the cache] ©2003-2008 | |||||||||||