Messages in this thread | | | Date | Thu, 25 May 2006 14:17:46 +0300 | From | Muli Ben-Yehuda <> | Subject | Re: [PATCH 1/4] x86-64: Calgary IOMMU - introduce iommu_detected |
| |
On Wed, May 24, 2006 at 11:19:56PM -0500, Jon Mason wrote: > On Thu, May 25, 2006 at 05:54:23AM +0200, Andi Kleen wrote: > > On Thursday 25 May 2006 05:34, Jon Mason wrote: > > > swiotlb relies on the gart specific iommu_aperture variable to know if > > > we discovered a hardware IOMMU before swiotlb initialization. Introduce > > > iommu_detected to do the same thing, but in a HW IOMMU neutral manner, > > > in preparation for adding the Calgary HW IOMMU. > > > > I applied them all. > > Fantastic!
Seconded :-)
> > But I think you broke the aperture setup. iommu_setup really > > needs to be called early, otherwise aperture.c doesn't get > > the right parameters. I undid that change. > > I'll take a look at that, but I did boot test these patches on my > opteron system and didn't notice anything wrong. Are the patches > available for me to look at on firstfloor?
ftp://ftp.firstfloor.org/pub/ak/x86_64/quilt/patches/
> > And please next time send against the latest tree. It required > > quite some tweaking to apply. > > Sorry, I pulled a the latest mercurial tree this morning, but I guess > that one is stale (or became stale over the day).
I guess Andi means the firstfloor tree, which has a number of other IOMMU related changes that are not in mainline yet. Let's take it for a spin.
Cheers, Muli - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |