| Date | Thu, 25 May 2006 18:43:53 +0800 | From | Wu Fengguang <> | Subject | Re: [PATCH 14/33] readahead: state based method - data structure |
| |
On Thu, May 25, 2006 at 04:03:31PM +1000, Nick Piggin wrote: > Wu Fengguang wrote: > > >Extend struct file_ra_state to support the adaptive read-ahead logic. > > > > Another nitpick: It is usually OK to do these things in the same patch > that actually uses the new data (or functions -- eg. patch 15). > > If the addition is complex or in a completely different subsystem > (eg. your rescue_pages function), _that_ can justify it being split > into its own patch. Then you might also prepend the subject with mm: > and cc linux-mm to get better reviews.
Ok, thanks for the advice.
Regards, Wu - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|