Messages in this thread | | | Date | Thu, 25 May 2006 22:35:15 +0159 | From | Jiri Slaby <> | Subject | Re: [PATCH 3/3] pci: gt96100eth use pci probing |
| |
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Ralf Baechle napsal(a): > On Wed, May 24, 2006 at 08:52:49PM -0400, Jeff Garzik wrote: > >> Jiri Slaby wrote: >>> gt96100eth use pci probing >>> >>> Convert pci_find_device to pci probing. Use dev_* macros for printing. >>> >>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com> > > The GT-96100 is not a PCI device but a system controller. The driver > just checkes for the PCI ID to ensure it is not by accident being loaded > on the wrong type of system. Which of course is suspect. If anything it > should become a platform device. Ooops. Ok, do you all agree to just remove pci_find_device() and add pci_get_device() + pci_dev_put()? (And maybe next patch with dev_* macros).
regards, - -- Jiri Slaby www.fi.muni.cz/~xslaby \_.-^-._ jirislaby@gmail.com _.-^-._/ B67499670407CE62ACC8 22A032CC55C339D47A7E -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFEdhUaMsxVwznUen4RAllLAJsEs5QVVkHojpljkShQRu28p53n6wCgsCkA /SuFkkLFIsC7ToR6FeGGhAE= =akyh -----END PGP SIGNATURE----- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |