![]() | |||||||||||
Messages in this thread |
Jon Mason wrote: >>From Andi Kleen's comments on the original Calgary patch, move > valid_dma_direction into the calling functions. > > Signed-off-by: Muli Ben-Yehuda <muli@il.ibm.com> > Signed-off-by: Jon Mason <jdmason@us.ibm.com> Even though BUG_ON() includes unlikely(), this introduces additional tests in very hot paths. _Why_ do we need this at all? I would prefer to NAK the patch, and fix the odd user that gets it wrong. It becomes REALLY obvious that a driver has gotten this wrong, REALLY quickly. I see no need to burden critical hot paths with dumb checks like this. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2006-05-25 06:37 [from the cache] ©2003-2008 | |||||||||||