lkml.org 
[lkml]   [2006]   [May]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/3] pci: bcm43xx kill pci_find_device
Jiri Slaby wrote:
> bcm43xx kill pci_find_device
>
> Change pci_find_device to safer pci_get_device.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> ---
> commit 75664d3c6fe1d8d00b87e42cc001cb5d90613dae
> tree ebcec31955a991f1661197c7e8bcdd682e030681
> parent 431ef31d431939bc9370f952d9510ab9e5b0ad47
> author Jiri Slaby <ku@bellona.localdomain> Thu, 25 May 2006 02:04:38 +0159
> committer Jiri Slaby <ku@bellona.localdomain> Thu, 25 May 2006 02:04:38 +0159
>
> drivers/net/wireless/bcm43xx/bcm43xx_main.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/bcm43xx/bcm43xx_main.c b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> index b488f77..f770f59 100644
> --- a/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> +++ b/drivers/net/wireless/bcm43xx/bcm43xx_main.c
> @@ -2142,9 +2142,10 @@ #ifdef CONFIG_BCM947XX
> if (bcm->pci_dev->bus->number == 0) {
> struct pci_dev *d = NULL;
> /* FIXME: we will probably need more device IDs here... */
> - d = pci_find_device(PCI_VENDOR_ID_BROADCOM, 0x4324, NULL);
> + d = pci_get_device(PCI_VENDOR_ID_BROADCOM, 0x4324, NULL);
> if (d != NULL) {
> bcm->irq = d->irq;
> + pci_dev_put(d);

Given the FIXME, if you are going to touch this area, it seems logical
to add a PCI device match table.

Jeff


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-25 02:48    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site