Messages in this thread | | | Date | Wed, 24 May 2006 11:48:41 +1000 | From | David Chinner <> | Subject | Re: [PATCH] Per-superblock unused dentry LRU lists. |
| |
On Tue, May 23, 2006 at 06:44:07PM -0700, Randy.Dunlap wrote: > On Wed, 24 May 2006 11:24:12 +1000 David Chinner wrote: > > +static void > > +dentry_lru_del_init(struct dentry *dentry) > > +{ > > + if (likely(!list_empty(&dentry->d_lru))) { > > + list_del_init(&dentry->d_lru); > > + dentry_stat.nr_unused--; > > + } > > +} > > + > > /* > > * This is dput > > * > > Please use regular kernel coding style for functions: > don't put qualifiers and names on separate lines.
Oops - I'm too used to the XFS coding style. Fixed.
> > @@ -377,6 +399,48 @@ static inline void prune_one_dentry(stru > > spin_lock(&dcache_lock); > > } > > > > +/* > > + * Shrink the dentry LRU on æ given superblock. > > on ? given superblock ?
"a". Fixed.
I'll wait for other comments before sending out an updated patch.
Cheers,
Dave. -- Dave Chinner R&D Software Enginner SGI Australian Software Group - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |