lkml.org 
[lkml]   [2006]   [May]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: cpusets: only wakeup kswapd for zones in the current cpuset
    On Mon, 22 May 2006, Paul Jackson wrote:

    > Three months ago, Christoph wrote:
    > > If we get under some memory pressure in a cpuset (we only scan zones
    > > that are in the cpuset for memory) then kswapd is woken
    > > up for all zones. This patch only wakes up kswapd in zones that are
    > > part of the current cpuset.
    > >
    > > Signed-off-by: Christoph Lameter <clameter@sgi.com>
    > >
    > > Index: linux-2.6.16-rc2/mm/page_alloc.c
    > > ===================================================================
    > > --- linux-2.6.16-rc2.orig/mm/page_alloc.c 2006-02-02 22:03:08.000000000 -0800
    > > +++ linux-2.6.16-rc2/mm/page_alloc.c 2006-02-08 00:05:09.000000000 -0800
    > > @@ -923,7 +923,8 @@ restart:
    > > goto got_pg;
    > >
    > > do {
    > > - wakeup_kswapd(*z, order);
    > > + if (cpuset_zone_allowed(*z, gfp_mask))
    > > + wakeup_kswapd(*z, order);
    > > } while (*(++z));
    > >
    > > /*
    > >
    >
    > Christoph,
    >
    > Does this patch serve any use? Chris Wright just noticed (in private
    > email) that wakeup_kswapd() already contains a check for cpuset
    > confinement, so it would seem the above added check is superfluous.

    None if that is the case.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-23 04:02    [W:0.023 / U:95.152 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site