Messages in this thread | | | Date | Mon, 22 May 2006 13:19:02 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH 4/9] namespaces: utsname: switch to using uts namespaces |
| |
On Mon, 22 May 2006 21:43:37 +0200 Cedric Le Goater wrote:
> Randy.Dunlap wrote: > >> > >> 9ee063adf4d2287583dbb0a71d1d5f80d7ae011f > >> diff --git a/arch/i386/kernel/sys_i386.c b/arch/i386/kernel/sys_i386.c > >> index 8fdb1fb..4af731d 100644 > >> --- a/arch/i386/kernel/sys_i386.c > >> +++ b/arch/i386/kernel/sys_i386.c > >> @@ -210,7 +210,7 @@ asmlinkage int sys_uname(struct old_utsn > >> if (!name) > >> return -EFAULT; > >> down_read(&uts_sem); > >> - err=copy_to_user(name, &system_utsname, sizeof (*name)); > >> + err=copy_to_user(name, utsname(), sizeof (*name)); > > > > It would be really nice if you would fix spacing while you are here, > > like a space a each side of '='. > > > > and a space after ',' in the function calls below. > > Here's a possible cleanup on top of serge's patchset as found in > 2.6.17-rc4-mm3.
Yes, thanks, looks good.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |