Messages in this thread | | | Date | Sun, 21 May 2006 05:09:51 -0700 | From | Andrew Morton <> | Subject | Re: + x86-move-vsyscall-page-out-of-fixmap-above-stack-tidy.patch added to -mm tree |
| |
Chris Wedgwood <cw@f00f.org> wrote: > > On Sun, May 21, 2006 at 02:51:54AM -0700, akpm@osdl.org wrote: > > > - if ((ret = insert_vm_struct(mm, vma))) { > > + ret = insert_vm_struct(mm, vma); > > + if (ret) { > > Urgh. > > It's not really any cleaner/clearer so why do that? >
Because it's cleaner and clearer and because Linus said.
One is an assignment and the other is a test. These have nothing to do with each other.
Keep it simple. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |