Messages in this thread | | | Date | Mon, 22 May 2006 02:14:03 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH] sector_t overflow in block layer |
| |
Hi!
> > Why isn't that just a > > > > if (unlikely(sector != (sector_t)sector)) > > > > and that's it? What does this have to do with CONFIG_LBD or BITS_PER_LONG, > > or anything at all? > > > > If the sector number fits in a sector_t, we're all good. > > I think you missed that Andrewas said he is worried about 64-bit overflows > as well. And you would not catch those with the sector !=
Can 64-bit really overflow? That's 16 000 Peta bytes, AFAICS. Does anyone really have disk array over 100 Peta bytes? How much space does Google have, for example? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |