lkml.org 
[lkml]   [2006]   [May]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 4/6] Have x86_64 use add_active_range() and free_area_init_nodes
    Andi Kleen <ak@suse.de> wrote:
    >
    >
    > > Well, it creates arch-neutral common code, teaches various architectures
    > > use it. It's the sort of thing we do all the time.
    > >
    > > These things are opportunities to eliminate crufty arch code which few
    > > people understand and replace them with new, clean common code which lots
    > > of people understand. That's not a bad thing to be doing.
    >
    > I'm not fundamentally against that, but so far it seems to just generate lots of
    > new bugs? I'm not sure it's really worth the pain.
    >

    It is a bit disproportionate. But in some ways that's a commentary on the
    current code. All this numa/sparse/flat/discontig/holes-in-zones/
    virt-memmap/ stuff is pretty hairy, especially in its initalisation.

    I'm willing to go through the pain if it ends up with something cleaner
    which more people understand a little bit.
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-21 00:57    [W:0.022 / U:29.412 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site