lkml.org 
[lkml]   [2006]   [May]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [netfilter-core] Re: [lockup] 2.6.17-rc3: netfilter/sctp: lockup in sctp_new(), do_basic_checks()

    * Patrick McHardy <kaber@trash.net> wrote:

    > > + /*
    > > + * Dont trust the initial offset:
    > > + */
    > > + offset = skb->nh.iph->ihl * 4 + sizeof(sctp_sctphdr_t);
    > > + if (offset >= skb->len)
    > > + return 1;
    > > +
    >
    > That part is unnecessary, the presence of one sctp_sctphdr_t
    > has already been verified by skb_header_pointer() in sctp_new().

    ok.

    > How about this patch (based on your patch, but typos fixed and also
    > covers nf_conntrack)?

    sure, fine with me!

    Ingo
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-02 16:36    [W:0.022 / U:91.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site