![]() | |||||||||||
Messages in this thread |
On Fri, 2006-05-19 at 12:03 +0200, Jörn Engel wrote: > > > And please create a structure containing both struct mtd_info and > > > struct nand_chip. Then use sizeof(that structure)... > > > > This format is used throughout the drivers/mtd/nand/ directory. I'd > > suggest it'd be more appropriate to have a separate patch that did this > > for all of them if it's desired, rather than having each driver do its > > own thing. It's fine as-is. The claim that it's nicer to introduce an extra datatype just for the allocation is subjective, at best. > > Agreed on all the spacing comments you raised; hangovers from toto.c > > that I used as a base. > > We have suboptimal code in the kernel, true. I still prefer new code > to have slightly higher standards, so the overall quality improves > slowly. Therefore, pointing to the other ugly duckling is not an > excuse for being mud-covered. ;) > > But you are right. The other ducklings could use a bath as well. They already got it. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ | ||||||||||
| Last update: 2006-05-19 12:29 [from the cache] ©2003-2008 | |||||||||||