Messages in this thread | | | Date | Thu, 18 May 2006 15:14:55 -0700 | From | Greg KH <> | Subject | Re: [PATCH] added support for ASIX 88178 chipset USB Gigabit Ethernet adaptor |
| |
On Thu, May 18, 2006 at 11:52:11PM +0200, Eduard Warkentin wrote: > Hi Greg! > > First of all, i hope you arent angry about having me sent this reply > as CC to the current maintainer and to the mailing list. If so, I > apologize, and it wont happen in future. > > > Hm, your tabs and spaces are messed up :( > I reviewed the original file again, and the lines just above mine > indeed have spare leading whitespaces. Shall I include changing them > in my patch?
No, your tabs got eaten by your email client, and it happened again:
> --- ./drivers/usb/net/asix.c.orig 2006-03-20 06:53:29.000000000 +0100 > +++ ./drivers/usb/net/asix.c 2006-05-18 01:18:52.000000000 +0200 > @@ -913,6 +913,10 @@ static const struct usb_device_id produc > USB_DEVICE (0x0b95, 0x7720), > .driver_info = (unsigned long) &ax88772_info, > }, { > + // ASIX AX88178 10/100/1000 > + USB_DEVICE (0x0b95, 0x1780), > + .driver_info = (unsigned long) &ax88772_info, > +}, { > // Linksys USB200M Rev 2 > USB_DEVICE (0x13b1, 0x0018), > .driver_info = (unsigned long) &ax88772_info,
See, tabs converted to spaces, not good :(
Care for a third try?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |