Messages in this thread | | | Date | Thu, 18 May 2006 21:57:56 +0400 | From | Stas Sergeev <> | Subject | Re: [patch] add input_enable_device() |
| |
Dmitry Torokhov wrote: > Yes, you are right. INPUT_DEVICE_ID_MATCH_BUS will not likely > benefit anyone. And according to the impression I've got, it should therefore be removed, sure? :)
> Consider this: pcspkr is broken at the moment as it does not > handle several simultaneous events well. If you fix it do behave > properly with SND_TONE and SND_BELL arriving at the same time > then adding hooks to the speaker code for snd-pcsp should be > pretty easy. See? I see the point but not the practicle solution. request_region() won't work as the ports are already claimed by other drivers. Resolving this inside pcspkr.c won't help snd-pcsp, as it will add the dependancy if some internal API is used. The real problem is that whereever I'll solve that, this will be a hack, because normally two drivers should not compete for the IO resourses, disable each other, race etc. So I give it up. I'll just disable pcspkr in the Kconfig and whoever wants both snd-pcsp and the beeps, will need to install the user-space daemon which uses uinput. I have yet to find such a daemon...
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |