lkml.org 
[lkml]   [2006]   [May]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectRe: [PATCH 000 of 3] md: Introduction - 3 bugfixs for -mm
    On Thursday May 18, reuben-lkml@reub.net wrote:
    >
    > However things appear still not quite right on boot, as each mount works but
    > displays as though it didn't work, ie:
    >
    > md: considering sdc2 ...
    > md: adding sdc2 ...
    > md: adding sda2 ...
    > md: created md0
    > md: bind<sda2>
    > md: bind<sdc2>
    > md: running: <sdc2><sda2>
    > raid1: raid set md0 active with 0 out of 2 mirrors
    >
    > 0 out of 2 ?

    That is fixed by this patch, which I thought I had submitted...
    Time get the latest -mm and see which of my patches are still pending
    I guess.

    Thanks,
    NeilBrown

    ------------------------------
    Fix recently broken calculation of degraded for raid1

    A recent patch broke this code: rdev doesn't have meaningful
    value at this point - disk->rdev is what should be used.

    Signed-off-by: Neil Brown <neilb@suse.de>

    ### Diffstat output
    ./drivers/md/raid1.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff ./drivers/md/raid1.c~current~ ./drivers/md/raid1.c
    --- ./drivers/md/raid1.c~current~ 2006-05-02 14:15:28.000000000 +1000
    +++ ./drivers/md/raid1.c 2006-05-02 14:15:44.000000000 +1000
    @@ -1889,7 +1889,7 @@ static int run(mddev_t *mddev)
    disk = conf->mirrors + i;

    if (!disk->rdev ||
    - !test_bit(In_sync, &rdev->flags)) {
    + !test_bit(In_sync, &disk->rdev->flags)) {
    disk->head_position = 0;
    mddev->degraded++;
    }
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-05-18 01:31    [W:0.021 / U:29.884 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site