lkml.org 
[lkml]   [2006]   [May]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [RFC][PATCH 1/2] Twofish cipher i586-asm optimized
    From
    On Sun, May 07, 2006 at 08:47:46PM +0000, Joachim Fritschi wrote:
    > After going over my patch again, i realized i missed the .cra_priority
    > and .cra_driver_name setting in the crypto api struct. Here is an updated
    > version of my patch:
    >
    > http://homepages.tu-darmstadt.de/~fritschi/twofish/twofish-i586-asm-2.6.17-2.diff

    Thanks for doing this Joachim. I like the result.

    But the duplicate key code is a bit too much. The fact that AES does
    it should only serve as a reminder for us to fix it, not to create even
    more duplication.

    So could you please move the key generation code into a separate file,
    say crypto/twofish-common.c which can then be shared by all twofish
    implementations?

    BTW, please include the actual patches the next time you submit them
    along with Signed-off-by lines. You should consult the file
    Documentation/SubmittingPatches for detailed instructions.

    Thanks,
    --
    Visit Openswan at http://www.openswan.org/
    Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
    Home Page: http://gondor.apana.org.au/~herbert/
    PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-16 09:47    [W:0.024 / U:1.568 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site