Messages in this thread | | | Date | Tue, 16 May 2006 11:48:12 -0400 | From | Jeff Garzik <> | Subject | Re: PATCH: Fix broken PIO with libata |
| |
Tejun Heo wrote: > Is this agreed upon? I tend to omit almost all unnecessary (by operator > precedence) parenthesis, so in new EH and all other stuff, the "a && b & > c" sort of lines are abundant. If this is something that's agreed upon, > I can do a clean sweep over those.
More parens == easier to review. So a && b & c should be a && (b & c)
to clearly delineate the separate expressions to the human eye, and also make it clear to the reader that the '&' is intended, and not a typo that should have been '&&'.
Anytime you see a long string of 'if' conditions, and the operators vary, add parents for readability.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |