lkml.org 
[lkml]   [2006]   [May]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] fix dangerous pointer derefs and remove pointless casts in MOXA driver
    On 15/05/06, Alan Cox <alan@redhat.com> wrote:
    > On Sun, May 14, 2006 at 03:49:35AM +0200, Jesper Juhl wrote:
    > > If mxser_write() gets called with a NULL 'tty' pointer, then the initial
    > > assignment of tty->driver_data to info will explode.
    >
    > If mxser_write gets called with a NULL pointer then you've already got such
    > serious problems it isn't worth checking
    >
    > > Please consider for inclusion.
    >
    > Just delete the checks. Also the little cast cleanup looks good so submit
    > that as a separate patch too.
    >

    Thank you for the feedback.
    I'll do that in two sepperate patches later this evening.

    --
    Jesper Juhl <jesper.juhl@gmail.com>
    Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
    Plain text mails only, please http://www.expita.com/nomime.html
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-15 11:56    [W:0.023 / U:60.924 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site