Messages in this thread | | | Date | Mon, 15 May 2006 23:41:52 +0200 | From | Patrick McHardy <> | Subject | Re: [PATCH] tcpdump may trace some outbound packets twice. |
| |
David S. Miller wrote: > From: Ranjit Manomohan <ranjitm@google.com> > Date: Mon, 15 May 2006 14:19:06 -0700 (PDT) > > >>Heres a new version which does a copy instead of the clone to avoid >>the double cloning issue. > > > I still very much dislike this patch because it is creating > 1 more clone per packet than is actually necessary and that > is very expensive. > > dev_queue_xmit_nit() is going to clone whatever SKB you send into > there, so better to just bump the reference count (with skb_get()) > instead of cloning or copying.
I think this would break the tc actions. Some actions call pskb_expand_head() on input, which BUGs on skb_shared(skb). They can't clone the skb instead because the functions doing that don't own it, the caller would continue with the old skb. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |