lkml.org 
[lkml]   [2006]   [May]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] mtd: fix memory leaks in phram_setup
    Date

    There are two code paths in drivers/mtd/devices/phram.c::phram_setup() that
    will leak memory.
    Memory is allocated to the variable 'name' with kmalloc() by the
    parse_name() function, but if we leave by way of the parse_err() macro,
    then that memory is never kfree()'d, nor is it ever used with
    register_device() so it won't be freed later either - leak.

    Found by the Coverity checker as #593 - simple fix below.


    Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
    ---


    drivers/mtd/devices/phram.c | 8 ++++++--
    1 files changed, 6 insertions(+), 2 deletions(-)


    --- linux-2.6.17-rc4-git2-orig/drivers/mtd/devices/phram.c 2006-03-20 06:53:29.000000000 +0100
    +++ linux-2.6.17-rc4-git2/drivers/mtd/devices/phram.c 2006-05-14 01:05:27.000000000 +0200
    @@ -266,12 +266,16 @@ static int phram_setup(const char *val,
    return 0;

    ret = parse_num32(&start, token[1]);
    - if (ret)
    + if (ret) {
    + kfree(name);
    parse_err("illegal start address\n");
    + }

    ret = parse_num32(&len, token[2]);
    - if (ret)
    + if (ret) {
    + kfree(name);
    parse_err("illegal device length\n");
    + }

    register_device(name, start, len);




    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-14 01:08    [W:0.022 / U:179.516 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site