lkml.org 
[lkml]   [2006]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH 26/35] Add Xen subarch reboot support
    * Pavel Machek (pavel@suse.cz) wrote:
    > Hi!
    >
    > > > +
    > > > +/* Ignore multiple shutdown requests. */
    > > > +static int shutting_down = SHUTDOWN_INVALID;
    > > > +static void __shutdown_handler(void *unused);
    > > > +static DECLARE_WORK(shutdown_work, __shutdown_handler, NULL);
    > > > +
    > > > +static int shutdown_process(void *__unused)
    > > > +{
    > > > + static char *envp[] = { "HOME=/", "TERM=linux",
    > > > + "PATH=/sbin:/usr/sbin:/bin:/usr/bin", NULL };
    > > > + static char *poweroff_argv[] = { "/sbin/poweroff", NULL };
    > >
    > > This should be configurable, probably in a sysctl
    >
    > Actually we have similar code in sparc and acpi parts, IIRC. We
    > probably want to have one, common, shut-me-off routine.

    Yep, I had that cleanup in mind, the patch said:

    TODO:
    - move poweroff and halt to generic similar to c_a_d

    thanks,
    -chris
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2006-05-12 23:57    [W:0.021 / U:1.972 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site