lkml.org 
[lkml]   [2006]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC][PATCH -rt] irqd starvation on SMP by a single process?
From
Date
On Fri, 2006-05-12 at 07:50 +0200, Ingo Molnar wrote:
> * john stultz <johnstul@us.ibm.com> wrote:
> > + if(!cpus_equal(current->cpus_allowed, irq_affinity[irq]));
> > + set_cpus_allowed(current, irq_affinity[irq]);
>
> > The patch below appears to correct this issue, however it also
> > repeatedly(on different irqs) causes the following BUG:
>
> ah. This actually uncovered a real bug. We were calling __do_softirq()
> with interrupts enabled (and being preemptible) - which is certainly
> bad.
>
> this was hidden before because the smp_processor_id() debugging code
> handles tasks bound to a single CPU as per-cpu-safe.
>
> could you check the (totally untested) patch below and see if that fixes
> things for you? I've also added your affinity change.

Yep, no BUG messages and I get irq affinity behavior that matches what I
echo into the proc interface.

Looks good to me so far. I'll keep running w/ it and let you know if we
see any issues.

thanks
-john

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-05-12 19:50    [W:0.136 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site