lkml.org 
[lkml]   [2006]   [May]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 001 of 8] md/bitmap: Fix online removal of file-backed bitmaps

    When "mdadm --grow /dev/mdX --bitmap=none" is used to remove
    a filebacked bitmap, the bitmap was disconnected from the array,
    but the file wasn't closed (until the array was stopped).

    The file also wasn't closed if adding the bitmap file failed.

    Signed-off-by: Neil Brown <neilb@suse.de>

    ### Diffstat output
    ./drivers/md/md.c | 7 +++++--
    1 file changed, 5 insertions(+), 2 deletions(-)

    diff ./drivers/md/md.c~current~ ./drivers/md/md.c
    --- ./drivers/md/md.c~current~ 2006-05-12 15:49:10.000000000 +1000
    +++ ./drivers/md/md.c 2006-05-12 15:54:48.000000000 +1000
    @@ -3588,10 +3588,13 @@ static int set_bitmap_file(mddev_t *mdde
    mddev->pers->quiesce(mddev, 1);
    if (fd >= 0)
    err = bitmap_create(mddev);
    - if (fd < 0 || err)
    + if (fd < 0 || err) {
    bitmap_destroy(mddev);
    + fd = -1; /* make sure to put the file */
    + }
    mddev->pers->quiesce(mddev, 0);
    - } else if (fd < 0) {
    + }
    + if (fd < 0) {
    if (mddev->bitmap_file)
    fput(mddev->bitmap_file);
    mddev->bitmap_file = NULL;
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-05-12 08:10    [W:0.020 / U:31.848 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site