Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [RFC PATCH 17/35] Segment register changes for Xen | Date | Thu, 11 May 2006 12:41:25 +0200 |
| |
On Thursday 11 May 2006 12:34, Avi Kivity wrote: > Pavel Machek wrote: > > Really? If someone does > > > > if (something) > > clearsegment(seg) > > somethingelse(); > > > > ... he'll get very confusing behaviour instead of compile error. > > > > Okay, that's weaker argument than expected... > > > > Also clearsegment(x) clearsegment(y); will compile when it should not. > > > > Also clearsegment(i++) will behave strangely. So perhaps > > > > #define clearsegment(seg) do { seg; } while (0) > > > > static inline void clearsegment(int seg) {}
It's all mood because the complete function is wrongly named and probably should just go.
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |