Messages in this thread | | | Subject | Re: [PATCH -mm] updated idetape gcc 4.1 warning fix | From | Daniel Walker <> | Date | Thu, 11 May 2006 10:14:37 -0700 |
| |
On Thu, 2006-05-11 at 14:11 +0100, Alan Cox wrote: > On Mer, 2006-05-10 at 11:10 -0700, Daniel Walker wrote: > > I added returns for failures .. I would hope that this doesn't break anything in > > userspace , but I'll confess that I have no way to determin that for certain . > > > > Hows that Alan? > > You still need to walk the BHs I think. Also if an error occurs and some > data is successfully transferred the standards explicitly require you > return the amount of data successfully transferred if you report an > error.
So it should try to write something even on an error ? It looks like it would be really difficult to drop the data off the BHs without actually doing the write .. The most straight forward way to handle the error would be write all the data copied ..
Daniel
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |