Messages in this thread | | | Date | Wed, 10 May 2006 03:24:49 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH][delayacct] Fix the timespec_sub() interface (was Re: [Patch 1/8] Setup) |
| |
Balbir Singh <balbir@in.ibm.com> wrote: > > Please find the updated patch, which changes the interface of timespec_sub() > as suggested in the review comments > > ... > > /* > - * sub = end - start, in normalized form > + * sub = lhs - rhs, in normalized form > */ > -static inline void timespec_sub(struct timespec *start, struct timespec *end, > - struct timespec *sub) > +static inline struct timespec timespec_sub(struct timespec *lhs, > + struct timespec *rhs) > {
I'd have thought that it would be more consistent and a saner interface to use pass-by-value:
static inline struct timespec timespec_sub(struct timespec lhs, struct timespec rhs)
It should generate the same code.
I mentioned this last time - did you choose to not do this for some reason, or did it just slip past?
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |