Messages in this thread | | | From | Hans Verkuil <> | Subject | Re: [v4l-dvb-maintainer] [PATCH] new driver for TLV320AIC23B | Date | Thu, 11 May 2006 00:42:34 +0200 |
| |
On Wednesday 10 May 2006 23:55, Scott Alfter wrote: > Signed-off-by: Scott Alfter <salfter@ssai.us> > > It took a little bit longer than I thought, but the attached patch > adds a driver for the TI TLV320AIC23B audio codec. It implements > analog audio capture at 32, 44.1, and 48 kHz (16-bit stereo). The > hardware is capable of more (it supports more sample rates and > includes analog output), but in its current form, the driver works > well with ivtv. > > The patch is attached; a test mailing indicated that Thunderbird > attaches patches inline instead of encoded. The patch is also > available from this URL: > > http://alfter.us/files/linux-2.6.16-tlv320aic23b.patch > > Scott Alfter > salfter@ssai.us
Hi Scott,
I've taken a quick look and I noticed a few things: first of all I recommend making a patch against the v4l-dvb repository as there have been a few changes compared to 2.6.16 that are relevant. In particular your device should start supporting VIDIOC_INT_G/S_AUDIO_ROUTING commands instead of VIDIOC_G/S_AUDIO. See the definition of these commands in v4l2-common.h for more info. This also implies that a media/tlv320aic23b.h header should be added (look at the existing headers such as wm8775.h).
I also noticed what seems to be a superfluous TODO in the VIDIOC_INT_AUDIO_CLOCK_FREQ implementation.
The enum (R7, R11, etc) isn't used and can be removed.
The input field of struct tlv320aic23b_state doesn't seem to be used, so that too can be removed.
You probably do not have to implement the VIDIOC_S_FREQUENCY command, that was wm8775 specific. I doubt it is necessary for this driver.
It is also a good idea to add support for older kernels to this driver (again, see the #if lines in the wm8775.c driver).
Hmm, well that seems to be it.
Thanks!
Hans - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |