Messages in this thread | | | Date | Wed, 10 May 2006 22:30:15 +0200 | From | Pavel Machek <> | Subject | Re: [RFC PATCH 17/35] Segment register changes for Xen |
| |
On St 10-05-06 22:09:04, Andi Kleen wrote: > On Tuesday 09 May 2006 09:16, Pavel Machek wrote: > > Hi! > > > > > --- linus-2.6.orig/include/asm-i386/mach-default/mach_system.h > > > +++ linus-2.6/include/asm-i386/mach-default/mach_system.h > > > @@ -1,6 +1,8 @@ > > > #ifndef __ASM_MACH_SYSTEM_H > > > #define __ASM_MACH_SYSTEM_H > > > > > > +#define clearsegment(seg) > > > > do {} while (0), please. > > It's not needed. Think about it.
Really? If someone does
if (something) clearsegment(seg) somethingelse();
... he'll get very confusing behaviour instead of compile error.
Okay, that's weaker argument than expected...
Also clearsegment(x) clearsegment(y); will compile when it should not.
Also clearsegment(i++) will behave strangely. So perhaps
#define clearsegment(seg) do { seg; } while (0)
is best variant? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |