Messages in this thread | | | Subject | Re: [PATCH 5 of 13] ipath - use proper address translation routine | From | Bryan O'Sullivan <> | Date | Mon, 01 May 2006 12:03:16 -0700 |
| |
On Mon, 2006-05-01 at 11:50 -0700, Roland Dreier wrote: > Bryan> Move away from an obsolete, unportable routine for > Bryan> translating physical addresses. > > This change: > > > - isge->vaddr = bus_to_virt(sge->addr); > > + isge->vaddr = phys_to_virt(sge->addr); > > is really wrong. bus_to_virt() is really what you want, because in > this case the address is a bus address that came from dma_map_xxx().
Well, bus_to_virt is not portable, so we definitely can't use it. I'll have to do some thinking about this.
<b
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |