Messages in this thread | | | Date | Mon, 1 May 2006 09:47:40 -0700 | From | Greg KH <> | Subject | Re: [PATCH 4a/4] MultiAdmin LSM (LKCS'ed) |
| |
On Mon, May 01, 2006 at 06:03:09PM +0200, Jan Engelhardt wrote: > > > Does Lindented suffice?
It's a good start, but you still need to fix things like:
> +#include <asm/siginfo.h> > +#include <linux/binfmts.h> > +#include <linux/capability.h> > +#include <linux/config.h> > +#include <linux/dcache.h> > +#include <linux/file.h> > +#include <linux/fs.h> > +#include <linux/init.h> > +#include <linux/ipc.h> > +#include <linux/kernel.h> > +#include <linux/module.h> > +#include <linux/moduleparam.h> > +#include <linux/namei.h> > +#include <linux/sched.h> > +#include <linux/securebits.h> > +#include <linux/security.h> > +#include <linux/sem.h> > +#include <linux/types.h>
asm #include goes last.
> +static inline void chg2_superadm(kernel_cap_t *); > +static inline void chg2_subadm(kernel_cap_t *); > +static inline void chg2_netadm(kernel_cap_t *); > +static inline int is_any_superadm(uid_t, gid_t); > +static inline int is_uid_superadm(uid_t); > +static inline int is_gid_superadm(gid_t); > +static inline int is_any_subadm(uid_t, gid_t); > +static inline int is_uid_subadm(uid_t); > +static inline int is_gid_subadm(gid_t); > +static inline int is_uid_netadm(uid_t); > +static inline int is_uid_user(uid_t); > +static inline int is_task1_user(const task_t *); > +static inline int is_task_user(const task_t *); > +static inline int range_intersect(uid_t, uid_t, uid_t, uid_t); > +static inline int range_intersect_wrt(uid_t, uid_t, uid_t, uid_t);
inline functions don't need definitions like this.
> +static gid_t Supergid = -1, Subgid = -1; > +static uid_t Superuid_start = 0, Superuid_end = 0, > + Subuid_start = -1, Subuid_end = -1, > + Netuid = -1, Wrtuid_start = -1, Wrtuid_end = -1; > +static int Secondary = 0;
Variables do not have capital letters.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |