lkml.org 
[lkml]   [2006]   [Apr]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH rc1-mm] de_thread: fix deadlockable process addition
Andrew Morton <akpm@osdl.org> wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> wrote:
> >
> > - if (likely(p->tasks.prev != LIST_POISON2))
> > + if (likely(p->tasks.prev != LIST_POISON2)) {
>
> argh.
>
> c'mon guys, we can't put a dependency on list_head poisoning into generic
> code.
>

A suitable fix might be to add a new list_del_poison() (or
list_del_rcu_something()?) and use that everywhere.

But it should use a different poisoning pattern, so we know that the kernel
will still work correctly when someone removes the list_head debugging.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-04-08 00:56    [W:0.139 / U:0.104 seconds]
©2003-2014 Jasper Spaans. Advertise on this site